Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file path favorites outside of allowlist shouldn't show up anywhere #3193

Open
johrstrom opened this issue Nov 17, 2023 · 0 comments · May be fixed by #3526
Open

file path favorites outside of allowlist shouldn't show up anywhere #3193

johrstrom opened this issue Nov 17, 2023 · 0 comments · May be fixed by #3526
Assignees
@Oglopf
Labels
bug Existing functionality not working as expected component/file_browser
Milestone
4.0

Comments

@johrstrom
Copy link
Contributor

While working on #3173 i noticed that favorites populate in the files dropdown, even if they're outside of the allowlist.

This shouldn't be the case. OodFilesApp#favorite_paths should adhere to the allowlist and never return any path outside of the allowlist.
@johrstrom johrstrom added bug Existing functionality not working as expected component/file_browser labels Nov 17, 2023
@johrstrom johrstrom added this to the 3.1 milestone Nov 17, 2023
@Oglopf Oglopf self-assigned this Feb 26, 2024
@johrstrom johrstrom modified the milestones: 3.1, 4.0 Mar 1, 2024
@Oglopf Oglopf mentioned this issue Mar 13, 2024
Closed
@Oglopf Oglopf linked a pull request Apr 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Oglopf Oglopf

Labels
bug Existing functionality not working as expected component/file_browser
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Fix favorites to consult allowlist OSC/ondemand
Fix favorites array population OSC/ondemand
2 participants
@johrstrom @Oglopf