Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

percy error on changed video load indicator #1108

Open
Br3nda opened this issue Aug 10, 2020 · 1 comment
Open

percy error on changed video load indicator #1108

Br3nda opened this issue Aug 10, 2020 · 1 comment

Comments

@Br3nda
Copy link
Member

Br3nda commented Aug 10, 2020

the video player within chrome and firefox show a video loading progress meter.

As of about 6 months ago, the videos are showing on the screen in the Percy tests as being partially loaded - it's a different amount of loaded every time the tests running, causing Percy to mark the pr as having a visual change that needs approval.

The easier solution is to mark the area as not visible using percy-css
https://docs.percy.io/docs/percy-specific-css

It would be best if we can still see the videos - so we can continue to test that they display, but find a way to only mark the load progress bar.

@Br3nda
Copy link
Member Author

Br3nda commented Sep 11, 2020

I've disabled percy until this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant