Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests due to incompatible Pillow upgrade #67

Closed
mikegerber opened this issue Jul 1, 2021 · 5 comments
Closed

Failing tests due to incompatible Pillow upgrade #67

mikegerber opened this issue Jul 1, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@mikegerber
Copy link
Collaborator

mikegerber commented Jul 1, 2021

https://app.circleci.com/pipelines/github/OCR-D/ocrd_calamari/175/workflows/945cc406-80f6-41b6-a24b-ff58f1a12c78/jobs/166

18:00:35.751 INFO processor.CalamariRecognize - INPUT FILE 0 / phys_0001
18:00:35.793 INFO ocrd.workspace.image_from_page - Cropping original image for page 'phys_0001'
18:00:35.815 INFO processor.CalamariRecognize - About to recognize 1 lines of region 'r_1_1'
18:00:35.817 WARNING processor.CalamariRecognize - Using raw image for line 'tl_1' in region 'r_1_1'
------------------------------ Captured log call -------------------------------
INFO     processor.CalamariRecognize:recognize.py:76 INPUT FILE 0 / phys_0001
INFO     ocrd.workspace.image_from_page:workspace.py:968 Cropping original image for page 'phys_0001'
INFO     processor.CalamariRecognize:recognize.py:88 About to recognize 1 lines of region 'r_1_1'
WARNING  processor.CalamariRecognize:recognize.py:100 Using raw image for line 'tl_1' in region 'r_1_1'
=========================== short test summary info ============================
FAILED test/test_recognize.py::test_recognize - TypeError: __array__() takes ...
FAILED test/test_recognize.py::test_recognize_with_checkpoint_dir - TypeError...
FAILED test/test_recognize.py::test_recognize_should_warn_if_given_rgb_image_and_single_channel_model
FAILED test/test_recognize.py::test_word_segmentation - TypeError: __array__(...
FAILED test/test_recognize.py::test_glyphs - TypeError: __array__() takes 1 p...
============================== 5 failed in 46.54s ==============================
Makefile:77: recipe for target 'test' failed
make[1]: *** [test] Error 1
make[1]: Leaving directory '/root/project'
Makefile:82: recipe for target 'coverage' failed
make: *** [coverage] Error 2
@mikegerber mikegerber self-assigned this Jul 1, 2021
@mikegerber mikegerber added the bug Something isn't working label Jul 1, 2021
@mikegerber
Copy link
Collaborator Author

mikegerber commented Jul 2, 2021

This is not related to #64, but caused by Pillow 8.3.0: The conversion line_image_np = np.array(line_image, dtype=np.uint8) fails now.

@kba FYI, You might see something similar elsewhere.

@mikegerber mikegerber changed the title Failing tests due to #64 Failing tests due to incompatible Pillow upgrade Jul 2, 2021
@mikegerber
Copy link
Collaborator Author

Pillow issue: python-pillow/Pillow#5571 and the PR fixing it: python-pillow/Pillow#5572

I'm expecting a new Pillow release to fix this.

@mikegerber
Copy link
Collaborator Author

@radarhere
Copy link

Pillow 8.3.1 has now been released.

@mikegerber
Copy link
Collaborator Author

mikegerber commented Jul 7, 2021

@radarhere Thanks for the service 😀

Tests are succeeding again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants