-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with recent PHPUnit (8) #132
Conversation
We use PHPUnit 7.5, which does not do any type definitions for Here the same question arises as in #130: are we planning to drop PHP 7.1 support? That seems to be the requirement for upgrading to PHPUnit 8, which requires at least PHP 7.2 to run. |
Hi,
Indeed it is. This syntax is already accepted by PHPUnit 7 this project is currently using, hence this proposal: the tests still pass with the current setup, and won’t break when updating PHPUnit. The PHP version used by this project is orthogonal to this PR, it may just make it a bit easier if it changes. |
Would love to do this in addition to then adding Sadly, because of upstream php-http/psr7-integration-tests we aren’t compatible with PHPUnit 8 at all. Adding the Not sure how I’d personally progress on this, I’ll leave that for @Nyholm to decide. |
Why add this, when the composer.json file doesn't allow PHPUnit 8? |
I don't really see any benefits for this at the moment. Sure, we can do it as "why not". But we need to make sure the test dependencies also support PHPUnit 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've update composer.json to support phpunit 8.
I've also made sure php-http/psr7-integration-tests
supports it too.
Thank you
No description provided.