Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for numeric headers to fromGlobals #44

Merged
merged 2 commits into from
May 10, 2021
Merged

Add support for numeric headers to fromGlobals #44

merged 2 commits into from
May 10, 2021

Conversation

takamichi
Copy link
Contributor

@takamichi takamichi commented Apr 22, 2021 •
edited

Fix #35 for fromGlobals.

Nyholm
Nyholm approved these changes May 10, 2021
View reviewed changes
Copy link
Owner

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, Good catch!

Thank you

@Nyholm Nyholm merged commit 5c24343 into Nyholm:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header with only numbers seems to cause exception
2 participants
@takamichi @Nyholm