Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio bundling error #212

Open
GeorgeMorozov opened this issue May 13, 2024 · 4 comments
Open

Visual Studio bundling error #212

GeorgeMorozov opened this issue May 13, 2024 · 4 comments

Comments

@GeorgeMorozov
Copy link

GeorgeMorozov commented May 13, 2024

I have a project on Framework 4.8, when I include your source through the "bundles system" built into Visual Studio I get an error:
image

The problem started in the version 3.0.1 In version 2.3.17 everything worked correctly.

@simonsarris
Copy link
Collaborator

I have no idea why this might happen. Does it happen if you only bundle GoJS, and none of the others?

@GeorgeMorozov
Copy link
Author

GeorgeMorozov commented May 13, 2024

This bundle contains files:

  • "go-{version}.js"
  • "PolylineLinkingTool.js"
  • "Figures.js"

but they have not changed, only the version of your file go.js has changed

PolylineLinkingTool.js. from this example https://gojs.net/latest/samples/PolylineLinking.html
Figures.js. from this example https://gojs.net/latest/intro/shapes.html

@WalterNorthwoods
Copy link
Contributor

WalterNorthwoods commented May 14, 2024

I bet the problem is that your PolylineLinkingTool.js is an old one that still depends on the Diagram.inherit static function, which can no longer exist in GoJS v3+. I suggest that you copy that file from the create-gojs-kit package, either from extensions/ if just loading from a script tag or from extensionsJSM/ if importing an ES module.

Please read https://gojs.net/latest/changelog.html, and especially https://gojs.net/latest/changelog.html#Changes.

@GeorgeMorozov
Copy link
Author

I removed the "PolylineLinkingTool.js", but it had no effect.
I had to stop minifying the bundle
by calling: scriptBundle.Transforms.Clear();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants