Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug_traceTransaction's disableMemory flag is different from geth #3972

Open
charles-cooper opened this issue Jun 1, 2023 · 2 comments
Open

debug_traceTransaction's disableMemory flag is different from geth #3972

charles-cooper opened this issue Jun 1, 2023 · 2 comments
Labels
status:ready This issue is ready to be worked on type:improvement

Comments

@charles-cooper
Copy link
Contributor

Version of Hardhat

2.14.0

What happened?

debug_traceTransaction's flag to disable memory is disableMemory: true, as opposed to geth's (contrapositive) enableMemory: false. cf. geth's traceConfig documentation

Minimal reproduction steps

see above

Search terms

debug_traceTransaction, disableMemory, enableMemory
@fvictorio
Copy link
Member

Damn. I think this used to exist in geth but it was changed in this PR. Long time ago though.

I guess we should add the enableMemory flag, deprecate disableMemory and remove it in the future.

@fvictorio fvictorio added status:ready This issue is ready to be worked on and removed status:triaging labels Jun 5, 2023
@charles-cooper
Copy link
Contributor Author

I think geth actually may accept both options. And anvil may follow hardhat's behavior here, need to double check though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on type:improvement
Projects
Hardhat
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fvictorio @charles-cooper