Add support for Redis 6 auth pass [user]
#1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Salakar can you please review it? |
|
@stockholmux I don't see, what am I missing? |
|
@gkorland Any updates on this? |
|
@Salakar can you please review this PR? |
|
@gkorland Looks good to me. |
|
@Salakar can you please review this PR? |
|
Any updates on this? |
|
Will this ever be merged? |
|
Not yet, it will be in the next couple if days |
leibale
reviewed
Mar 8, 2021
leibale
previously approved these changes
Mar 8, 2021
gkorland
commented
Mar 9, 2021
| @@ -61,7 +61,7 @@ describe('client authentication', function () { | |||
| }); | |||
| var tmp = client.command_queue.get(0).callback; | |||
| client.command_queue.get(0).callback = function (err, res) { | |||
| client.auth = function (pass, callback) { | |||
| client.auth = function (pass, user, callback) { | |||
|
@leibale why does the lint fail? |
|
@gkorland IDK whats doing on, it seems like it's running old workflows |
znarf
added a commit
to opencollective/opencollective-api
that referenced
this pull request
Jul 28, 2021
problem related to redis/node-redis#1508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pending NodeRedis/redis-commands#35