Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create patched versions of python packaging tools to avoid version checks #158892

Closed
jonringer opened this issue Feb 10, 2022 · 3 comments
Closed

Comments

@jonringer
Copy link
Contributor

Describe the bug

Versioning within python is usually a determinate to us. Should we just modify the main packaging packages to allow for a --skip-version-check option?

cc @FRidh @mweinelt @fabaff @dotlambda

@FRidh
Copy link
Member

FRidh commented Feb 10, 2022

I don't understand quite what you mean here. Do you want that buildPython* has an option to disable version checks altogether? Or should it be able to ignore just constraints related to a specific package? pip already supports this when building a wheel, and so does build #105714.

@jonringer
Copy link
Contributor Author

Do you want that buildPython* has an option to disable version checks altogether?

I would like for that to be the default, as there a lot of patching done as it's not expect to explicitly disable it.

pip already supports this when building a wheel, and so does build #105714.

Sure, but setuptools and other pep517 tools also do their own version checking. I was referring to these. and making pip always disabled by default.

@jonringer
Copy link
Contributor Author

pythonRelaxDepsHook now exists. No longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants