Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing enhancement #170

Open
ariG23498 opened this issue Nov 26, 2020 · 3 comments
Open

Processing enhancement #170

ariG23498 opened this issue Nov 26, 2020 · 3 comments

Comments

@ariG23498
Copy link
Contributor

I do not think that while parsing the docstrin we should be using regex on each line of the docstring.

Suppose:

Args:
    arg1 (int): This is a one liner
    arg2 (int): This
                    takes
                    multiple
                    lines

If we split the lines and apply regex then in the following block


we will not be able to harness the description properly.

We can probably use something else here.

@NiklasRosenstein
Copy link
Owner

Hey @ariG23498 , it may not be super clean, but it's low effort and I think it works? I've added a test case for a parameter with multiple lines in the description. Please review 1084842

@NiklasRosenstein
Copy link
Owner

(Note something else is broken in the commit mentioned above but the unittest does pass)

@ariG23498
Copy link
Contributor Author

ariG23498 commented Nov 28, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants