Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip "Media Group UUID" exif from JPEG images #121

Open
NfNitLoop opened this issue Jun 15, 2023 · 1 comment
Open

Strip "Media Group UUID" exif from JPEG images #121

NfNitLoop opened this issue Jun 15, 2023 · 1 comment

Comments

@NfNitLoop
Copy link
Owner

Scenario:

  • User has an HEIC image on their phone.
  • User attaches it to a post.
  • Safari on iOS automatically converts the HEIC image to JPEG.
  • Instead of re-using the "Media Group UUID" from the HEIC, it creates a new, random UUID.

If the user ever uploads the image again, it has different file contents, thus a different hash, and breaks content-addressable store. Leads to:

@NfNitLoop
Copy link
Owner Author

Brainstorming:

Q: Should I just strip all exif data out of images?

A: No. If I'm working on a computer and I drag a file in, I may want the exif metadata to stay present. We shouldn't modify files without users' consent. (Though, we may want a separate feature to warn people about exif metadata. GPS in particular.)

… But Safari (only on iOS?) creating images w/ different UUIDs with every upload feels more like a bug. So maybe limit the stripping to

  • Just that field (Maybe replacing it with all 0s)
  • Only on iOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant