diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a1991fc..f124b47 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -18,6 +18,9 @@ jobs: - ubuntu-18.04 - windows-latest - macos-latest + # Don't fail fast, if we have a failure on a specific matrix type + # we want to know which ones: + fail-fast: false runs-on: ${{ matrix.os }} diff --git a/src/tests.rs b/src/tests.rs index 72ec9c6..ad0077b 100644 --- a/src/tests.rs +++ b/src/tests.rs @@ -1,5 +1,4 @@ -use std::{fs::DirEntry, io, os::windows::prelude::MetadataExt, path::Path}; - +use std::{fs::DirEntry, io, path::Path}; // TODO: These are equivalent and bs58 seems better. migrate. // Test that our base58 encoder can encode/decode arbitrary bytes. @@ -121,7 +120,7 @@ fn no_ntfs_ads() -> Result<(), failure::Error> { // I don't see any way in std:: to directly list NTFS data streams, but // Windows/Rust report file sizes w/o alternate data streams, so I'm // using this as a proxy for that. - if md.file_size() == 0 { + if md.len() == 0 { println!("ERROR: 0 byte file: {}", entry.path().to_str().unwrap_or("Unknown file")); found_files += 1; } @@ -172,4 +171,4 @@ fn walk_files>(dir_path: P) -> Result