Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When rolling back, we should show which permissions got restored #47

Open
mcpeak opened this issue Sep 8, 2017 · 2 comments
Open

When rolling back, we should show which permissions got restored #47

mcpeak opened this issue Sep 8, 2017 · 2 comments

Comments

@mcpeak
Copy link
Contributor

mcpeak commented Sep 8, 2017

Similar to how we do when repoing, we should show which permissions got restored after a rollback.

@Mortinke
Copy link

Mortinke commented Nov 23, 2017

Is not this already implemented in the current version?

I restored this morning a role and got the right information:

Resore will return these permissions:
ec2:describetags

(venv) ubuntu@**********:/usr/local/src/repokid$ repokid rollback_role *************** MailRelay-EC2CustomMetricsRole-1E34E52V15AP9 --selection=0 -c
Loaded config from /usr/local/src/repokid/config.json
Will restore the following policies:
{u'root': {u'Statement': [{u'Action': [u'cloudwatch:PutMetricData',
                                       u'cloudwatch:GetMetricStatistics',
                                       u'cloudwatch:ListMetrics',
                                       u'ec2:DescribeTags'],
                           u'Effect': u'Allow',
                           u'Resource': u'*'}],
           u'Version': u'2012-10-17'}}
Current policies:
{'root': {u'Statement': [{u'Action': [u'cloudwatch:PutMetricData',
                                      u'cloudwatch:GetMetricStatistics',
                                      u'cloudwatch:ListMetrics'
                          u'Effect': u'Allow',
                          u'Resource': u'*'}],
          u'Version': u'2012-10-17'}}

Resore will return these permissions:
ec2:describetags

@mcpeak
Copy link
Contributor Author

mcpeak commented Nov 25, 2017

We'll show the full version of the policy we're putting back but not a diff that makes it explicit which permissions that would add. I think it would be useful to have both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants