Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate all docstrings #44

Open
mcpeak opened this issue Sep 8, 2017 · 3 comments
Open

Validate all docstrings #44

mcpeak opened this issue Sep 8, 2017 · 3 comments

Comments

@mcpeak
Copy link
Contributor

mcpeak commented Sep 8, 2017

The docstrings for functions may have drifted. Would be nice to read through all the function docstrings and make sure the arguments are correct and the descriptions are clear.

@yash1th
Copy link

yash1th commented Nov 21, 2017

Hi @mcpeak,

This would be my first OSS contribution. Do you want to check the existing docstrings of functions and see whether their descriptions and arguments are correct and clear?

@mcpeak
Copy link
Contributor Author

mcpeak commented Nov 21, 2017

Hi @yash1th , awesome! Thanks for contributing. The point here is to make sure that for all functions we're listing the correct parameters in the docstring. So if a function takes three arguments all the arguments are listed (and described if not obvious) in the docstring. Thanks!

@JohnVonNeumann
Copy link
Contributor

JohnVonNeumann commented Apr 22, 2018

So I did a grep -lr "\"\"\"" --exclude-dir=venv-rk/ --exclude-dir=.git to find all files where this would be required:

""" Formatted Docstrings:

  • repokid/init.py

  • repokid/hooks/init.py

  • repokid/cli/repokid_cli.py

  • repokid/utils/dynamo.py

  • repokid/utils/roledata.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants