Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of NoOpPreparsedDocumentProvider #994

Merged
merged 1 commit into from Apr 19, 2022

Conversation

kilink
Copy link
Member

@kilink kilink commented Apr 19, 2022

NoOpPreparsedDocumentProvider is marked as internal in graphql-java; however, it is
the default PreparsedDocumentProvider used by the GraphQL.Builder, so we can use it
by virtue of simply not passing anything in when no PreparsedDocumentProvider bean
is available.

NoOpPreparsedDocumentProvider is marked as internal in graphql-java; however, it is
the default PreparsedDocumentProvider used by the GraphQL.Builder, so we can use it
by virtue of simply not passing anything in when no PreparsedDocumentProvider bean
is available.
@berngp berngp merged commit cb809d1 into master Apr 19, 2022
@berngp berngp deleted the remove-no-op-preparsed-document-provider branch April 19, 2022 17:39
@berngp
Copy link
Contributor

berngp commented Apr 19, 2022

Thanks @kilink and @jord1e

@jord1e
Copy link
Contributor

jord1e commented Apr 20, 2022

Glad this is resolved.

I now know about ObjectProvider :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants