Add support for defining a default DataFetcherFactory via autoconfig #979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
first
Pull Request type
Changes in this PR
By default a
PropertyDataFetcher
will be configured when no data fetcher has been specified. You can provide a customDataFetcherFactory
toGraphQLCodeRegistry
which gives you the ability to change this default behaviour.I have been doing some work on dynamically generating the
PropertyDataFetcher
logic directly (instead ofPropertyDataFetcher
's reflection behaviour) in a class using the ASM bytecode library: https://github.com/jord1e/graphql-java-asm-datafetcherBy simply providing a
AsmDataFetcherFactory
the required classes get generated lazily, increasing performance by 10x+, matching handwritten data fetchers, in my initial testing (I will further work on this proof of concept to make it better match the defaultPropertyDataFetcher
i.e. add generic Map<Object, Object> support).This is not the only use-case of course but the ability to define a
DataFetcherFactory
as a bean is a low maintaince thing we can do.Alternatives considered
N/A, Spring for GraphQL has a way to customize the GraphQL instance, I don't think DGS has this.