Replace Javafaker with Datafaker #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodiam
changed the title
berngp
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Javafaker with Datafaker since the former is no longer maintained.
Pull request checklist
first - Considered, but it's a tiny change
Pull Request type
Changes in this PR
Replaced Java faker with Datafaker (note: I'm one of the contributors). Datafakeris a direct fork of Javafaker and was created because Java faker has a few security issues, several bugs, and is no longer maintained (no release for 2+ years). Datafaker is very similar in terms of API, but is maintained, and we release new features and bugfixes every month.
Alternatives considered
NA