Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added operation name in query input and passed in execute method #941

Conversation

PrasoonJain
Copy link

Pull request checklist

  • Please read our contributor guide
  • Consider creating a discussion on the discussion forum
    first
  • Make sure the PR doesn't introduce backward compatibility issues
  • Make sure to have sufficient test cases

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

Fixes this issue - #672
Discussion here -> #884
Issue #

Alternatives considered

Describe alternative implementation you have considered

@srinivasankavitha
Copy link
Contributor

PR changes look good, thanks for the fixes. You do seem to have a build failure:

e: .../prasoon/dgs-framework/graphql-dgs-spring-webflux-autoconfigure/src/main/kotlin/com/netflix/graphql/dgs/webflux/handlers/DefaultDgsWebfluxHttpHandler.kt: (39, 50): No value passed for parameter 'operationName'

@PrasoonJain
Copy link
Author

PR changes look good, thanks for the fixes. You do seem to have a build failure:

e: .../prasoon/dgs-framework/graphql-dgs-spring-webflux-autoconfigure/src/main/kotlin/com/netflix/graphql/dgs/webflux/handlers/DefaultDgsWebfluxHttpHandler.kt: (39, 50): No value passed for parameter 'operationName'

Hi @srinivasankavitha , I have fix the build failure. Build is working fine now. Please re-approve build check runs

@srinivasankavitha srinivasankavitha merged commit e2467e7 into Netflix:master Mar 22, 2022
@PrasoonJain
Copy link
Author

Hi @srinivasankavitha When is the next release planned ? Just wanted to understand on by when can I have this change live ?

@srinivasankavitha
Copy link
Contributor

srinivasankavitha commented Mar 23, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants