Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix : graphiql/index.html does not replace fetch path #737

Merged
merged 5 commits into from Nov 23, 2021
Merged

bugfix : graphiql/index.html does not replace fetch path #737

merged 5 commits into from Nov 23, 2021

Conversation

heoYH
Copy link

@heoYH heoYH commented Nov 16, 2021 •
edited

Pull request checklist

  • Please read our contributor guide
  • Consider creating a discussion on the discussion forum
    first
  • Make sure the PR doesn't introduce backward compatibility issues
  • Make sure to have sufficient test cases

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

#725 have bug (graphiql/index.html does not replace fetch path)

Alternatives considered

  • configProps.graphiql.path + "/index.html" route delete
  • add custom graphiql path to ResourceHandlerRegistry.addResourceHandler
  • add graphiql/index.html fetch path test

@heoYH heoYH mentioned this pull request Nov 22, 2021
Closed
@berngp berngp merged commit 13add6b into Netflix:master Nov 23, 2021
@berngp
Copy link
Contributor

berngp commented Nov 23, 2021

thanks @heoYH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heoYH @berngp @heo-d