DefaultDgsFederationResolver now handles failed completion stages ret… #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urned from entity fetchers properly
|
Thanks for the PR @victorlevasseur. Will test this out and get back to you shortly. |
berngp
approved these changes
Nov 11, 2021
victorlevasseur
deleted the
bugfix/entity-fetcher-failed-completion-stage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urned from entity fetchers properly
Pull request checklist
first
Pull Request type
Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #726
It allows the DefaultDgsFederationResolver to properly handle exceptions thrown by failed completable futures.
I used the dataloader Try object to ease the handling of exception and to make sure to have a single path of execution for exceptions thrown in the entity fetcher body and also the exceptions thrown by failed completable futures. That's why the whole call to each entity fetchers are wrapped in Try.tryCallable (to handle exceptions thrown directly in the entity fetcher) and then unwrapped when combined with the result of the CompletableFuture (to handle exceptions thrown by a failed completable future).
I added a new tests to check that this use case now works.