Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : enable to set dgs.graphql.graphiql.path in webflux #725

Merged
merged 1 commit into from Nov 10, 2021

Conversation

heoYH
Copy link

@heoYH heoYH commented Nov 8, 2021

Pull request checklist

  • Please read our contributor guide
  • Consider creating a discussion on the discussion forum
    first
  • Make sure the PR doesn't introduce backward compatibility issues
  • Make sure to have sufficient test cases

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

dgs.graphql.graphiql.path(https://netflix.github.io/dgs/configuration/) configuration does not work in webflux

Alternatives considered

  • add graphiql path property in DgsWebfluxConfigurationProperties
  • change the redirect path to 'dgs.graphql.graphiql.path' + /index.html
  • 'dgs.graphql.graphiql.path'+/index.html path request is return the "classpath:/static/graphiql/index.html" resource
  • add custom path test case

@berngp
Copy link
Contributor

berngp commented Nov 10, 2021

Thanks for the PR @heoYH .

@berngp berngp merged commit 4297da5 into Netflix:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants