Add hints for subscription OperationMessage's payload serialization. #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea of this commit is to aid Jackson infer the content of the `OperationMessage` payload by adding the `@JsonSubType` hint. With this we can tell Jackson that the type could be either... * empty, via the EmptyPayload class. * data, via the DataPayload class. * query, via the QueryPayload class
berngp
force-pushed
the
feature/sse-subscription-operation-message
branch
from
62bbb03
to
36ea67e
Compare
...ubscription-types/src/main/kotlin/com/netflix/graphql/types/subscription/OperationMessage.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Context
Users are observing that some of the fields are being dropped from the subscription messages, specifically the
"type":"SUBSCRIPTION_DATA". This is causing issues with clients that assumed that such field would exist to be able to identify what kind of message it was.Changes in this PR
The idea of this commit is to aid Jackson infer the content of the
OperationMessagepayload by adding the@JsonSubTypehint.With this we can tell Jackson that the type could be either...