You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The @Deprecated("The RequestExecutor should be provided while creating the implementation.", ReplaceWith("Example: new DefaultGraphQLClient(url, requestExecutor);")) points toDefaultGraphQLClient, which is deprecated as well.
We need to suggest either CustomGraphQLClient, CustomReactiveGraphQLClient and WebClientGraphQLClient.
Creating a guide on when to use each of the clients mentioned above will help as well as provide examples of migrating from the deprecated method calls to the new clients.
The text was updated successfully, but these errors were encountered:
I think we are just missing a simple change in the GraphQLClient.kt file. Right now it reads...
graphql-dgs-client/src/main/kotlin/com/netflix/graphql/dgs/client/GraphQLClient.kt
59: @Deprecated("The RequestExecutor should be provided while creating the implementation.", ReplaceWith("Example: new DefaultGraphQLClient(url, requestExecutor);"))
62: @Deprecated("The RequestExecutor should be provided while creating the implementation.", ReplaceWith("Example: new DefaultGraphQLClient(url, requestExecutor);"))
116: @Deprecated("The RequestExecutor should be provided while creating the implementation.", ReplaceWith("Example: new DefaultGraphQLClient(url, requestExecutor);"))
123: @Deprecated("The RequestExecutor should be provided while creating the implementation.", ReplaceWith("Example: new DefaultGraphQLClient(url, requestExecutor);"))
What are you missing in the docs
The
@Deprecated("The RequestExecutor should be provided while creating the implementation.", ReplaceWith("Example: new DefaultGraphQLClient(url, requestExecutor);"))
points toDefaultGraphQLClient
, which is deprecated as well.We need to suggest either
CustomGraphQLClient
,CustomReactiveGraphQLClient
andWebClientGraphQLClient
.Creating a guide on when to use each of the clients mentioned above will help as well as provide examples of migrating from the deprecated method calls to the new clients.
The text was updated successfully, but these errors were encountered: