Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from the deprecated GraphQL Java Instrumentation methods. #1334

Merged
merged 1 commit into from Nov 30, 2022

Conversation

berngp
Copy link
Contributor

@berngp berngp commented Nov 26, 2022

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

This commit adopts the new GraphQL Java 19 Instrumentation methods. In addition, we are adding metadata information about the properties that can be used to customize the metrics, and tags associated with those metrics, in DGS.

This commit adopts the new GraphQL Java 19 Instrumentation methods.
In addition, we are adding metadata information about the properties
that can be used to customize the metrics, and tags associated with
those metrics, in DGS.
Copy link
Collaborator

@tinnou tinnou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berngp berngp merged commit 471dc4f into master Nov 30, 2022
@berngp berngp deleted the feature/micrometer branch November 30, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants