Make session security context available for both WebSocket protocols #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuseinJ
changed the title
HuseinJ
changed the title
srinivasankavitha
approved these changes
Nov 9, 2022
|
Does this also work with ReactiveSecurityContextHolder for webflux? |
|
@scon-io I think it should work. Unfortunately these changes are not released yet - You could try it out by building it locally. |
|
We will be doing a release around end of next week, including these changes. Sent from my iPhoneOn Nov 24, 2022, at 1:17 AM, husein-ftapi ***@***.***> wrote:
@scon-io I think it should work. Unfortunately these changes are not released yet - You could try it out by building it locally.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
@srinivasankavitha Thank you very much for the info :-) I'm happy to hear that this will soon be released 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
first
Pull Request type
Changes in this PR
Initial Issue see: #814 - This fixes a bug where we do not receive the SecurityContext when using
WebsocketGraphQlTransportWSProtocoll. The logic which is used inWebsocketGraphQLWSProtocolHandlerwhere the SecurityContext is loaded from the session, should be called regardless of which protocol is used. So i moved the logic up again toDgsWebSocketHandlerwhere it was before so it gets calledAlternatives considered