Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the ability to turn off the BigDecimal and BigInteger extended scalars #1311

Merged
merged 1 commit into from Nov 8, 2022

Conversation

berngp
Copy link
Contributor

@berngp berngp commented Nov 8, 2022

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

This commit enables developers to turn off the BigDecimal and/or BigInteger Extended Scalars. This is done via the

  • dgs.graphql.extensions.scalars.numbers.bigdecimal.enabled
  • dgs.graphql.extensions.scalars.numbers.biginteger.enabled

Alternatives considered

Provide a more generic auto-configuraiton setup that allows developers to enable/disable extended scalars by name.

@berngp berngp force-pushed the feature/bigdecimal-enable-flag branch 2 times, most recently from b45c380 to e0546e3 Compare November 8, 2022 03:01
…calars.

This commit enables developers to turn off the BigDecimal and/or
BigInteger Extended Scalars. This is done via the

* dgs.graphql.extensions.scalars.numbers.bigdecimal.enabled
* dgs.graphql.extensions.scalars.numbers.biginteger.enabled
@berngp berngp force-pushed the feature/bigdecimal-enable-flag branch from e0546e3 to 0be45a1 Compare November 8, 2022 19:41
@srinivasankavitha srinivasankavitha merged commit 6aff9aa into master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants