Rework the API expressed by DgsExecutionResult #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berngp
force-pushed
the
feature/rework-DgsExecutionResult-API
branch
from
40bb395
to
f861fc1
Compare
kilink
reviewed
Oct 27, 2022
graphql-dgs/src/main/kotlin/com/netflix/graphql/dgs/DgsExecutionResult.kt
Outdated
Show resolved
Hide resolved
kilink
reviewed
Oct 27, 2022
graphql-dgs/src/main/kotlin/com/netflix/graphql/dgs/DgsExecutionResult.kt
Outdated
Show resolved
Hide resolved
kilink
reviewed
Oct 27, 2022
graphql-dgs/src/main/kotlin/com/netflix/graphql/dgs/DgsExecutionResult.kt
Outdated
Show resolved
Hide resolved
kilink
approved these changes
Oct 27, 2022
berngp
force-pushed
the
feature/rework-DgsExecutionResult-API
branch
from
f861fc1
to
fa6ebcb
Compare
srinivasankavitha
approved these changes
Oct 28, 2022
* We are adopting a Builder pattern instead of depending on Kotlin delegation for the ExecutionResult. This was done to expose a cleaner API for Java Consumers. * We are also moving the `DgsExecutionResult` to not be _internal_, since at is clear from the `MyInstrumentation` example developers will be using it explicitly.
berngp
force-pushed
the
feature/rework-DgsExecutionResult-API
branch
from
fa6ebcb
to
27401d3
Compare
|
Ah, I didn't consider these things, sorry! These are good changes, thanks for the refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
DgsExecutionResultto not be internal, since at is clear from theMyInstrumentationexample developers will be using it explicitly.