Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using deprecated auth method #99

Closed
carlpett opened this issue Feb 18, 2020 · 3 comments
Closed

Using deprecated auth method #99

carlpett opened this issue Feb 18, 2020 · 3 comments
Assignees

Comments

@carlpett
Copy link

carlpett commented Feb 18, 2020

Hi!
It seems shepherd is using the auth method Github is in process of deprecating: https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param (I get an email from Github about using it when running shepherd).
Is there some dependency you need to bump, or is this in shepherd itself?

@nwalters512
Copy link
Member

Good catch! This is indeed Shepherd's fault. The way we do auth with the @octokit/rest client is now deprecated: https://github.com/octokit/rest.js/issues/1588. This should be a pretty straightforward fix - feel free to open up a PR, or let us know if you won't have the bandwidth for that and we can take care of it!

@aorinevo
Copy link
Collaborator

aorinevo commented Apr 6, 2020

Hi @carlpett and @nwalters512, happy to help resolve this issue but currently side-tracked with tackling shepherd vulnerabilities through dependency management (see issue #103 )

@aorinevo
Copy link
Collaborator

I believe this has been addressed. If not, feel free to reopen.

@aorinevo aorinevo self-assigned this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants