Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency Management Part II: Update jest #108

Closed
aorinevo opened this issue Apr 8, 2020 · 5 comments · Fixed by #113
Closed

Dependency Management Part II: Update jest #108

aorinevo opened this issue Apr 8, 2020 · 5 comments · Fixed by #113
Assignees
@parshap @aorinevo
Labels
dependencies Pull requests that update a dependency file released

Comments

@aorinevo
Copy link
Collaborator

aorinevo commented Apr 8, 2020 •
edited

Introduction

This issue picks up where issue #103 leaves off. In particular, this issue addresses bringing jest and jest related dependencies up-to-date.

Proposed Change

  • Remove jest-plugin-fs dependency in favor of using local artifacts
    • Idea here is to use a few publicly accessible github repos
  • Test each shepherd cli command

ROI

  • Resolves remaining 206 vulnerabilities
  • Unit tests more aligned with user actions
@aorinevo aorinevo self-assigned this Apr 8, 2020
@aorinevo aorinevo added the dependencies Pull requests that update a dependency file label Apr 8, 2020
@aorinevo aorinevo mentioned this issue Apr 9, 2020
Merged
@aorinevo
Copy link
Collaborator Author

aorinevo commented Apr 9, 2020 •
edited

@parshap, PR #113 is ready for review.

@aorinevo
Copy link
Collaborator Author

aorinevo commented Apr 9, 2020

Screenshots:
Screen Shot 2020-04-09 at 3 06 18 AM
Screen Shot 2020-04-09 at 3 06 40 AM

@aorinevo
Copy link
Collaborator Author

aorinevo commented Apr 9, 2020

TravisCI is failing. I’ll take a look at it tomorrow.

@aorinevo
Copy link
Collaborator Author

Correpsonding PR #113

@aorinevo
Copy link
Collaborator Author

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parshap parshap

@aorinevo aorinevo

Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update jest aorinevo/shepherd
2 participants
@parshap @aorinevo