Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endianness when reading the extra field of a gzip header #176

Closed
wants to merge 1 commit into from

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Oct 8, 2022

As specified in RFC1952 §2.1 multi-byte values are stored in little endian format.

Fixes #175

As specified in RFC1952 §2.1 multi-byte values are stored in little
endian format.
@Nemo157
Copy link
Member Author

Nemo157 commented Oct 8, 2022

bors r+

bors bot added a commit that referenced this pull request Oct 8, 2022
176: Fix endianness when reading the `extra` field of a gzip header r=Nemo157 a=Nemo157

As specified in RFC1952 §2.1 multi-byte values are stored in little endian format.

Fixes #175 

Co-authored-by: Wim Looman <git@nemo157.com>
@codecov-commenter
Copy link

Codecov Report

Base: 78.03% // Head: 78.36% // Increases project coverage by +0.33% 🎉

Coverage data is based on head (7118845) compared to base (7932607).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           prīmum     #176      +/-   ##
==========================================
+ Coverage   78.03%   78.36%   +0.33%     
==========================================
  Files          94       94              
  Lines        3068     3069       +1     
==========================================
+ Hits         2394     2405      +11     
+ Misses        674      664      -10     
Impacted Files Coverage Δ
src/codec/gzip/header.rs 88.88% <100.00%> (+15.87%) ⬆️
tests/gzip.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bors bors bot closed this Oct 8, 2022
@Nemo157 Nemo157 deleted the fix-gzip-extra-endian branch October 8, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants