Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zstd to 0.10 #131

Closed
wants to merge 1 commit into from
Closed

Update zstd to 0.10 #131

wants to merge 1 commit into from

Conversation

vmalloc
Copy link

@vmalloc vmalloc commented Nov 8, 2021

No description provided.

@indygreg
Copy link
Contributor

indygreg commented Jan 2, 2022

Gentle nudge on this PR. The current async-compression release on crates.io is using version 0.7 of the zstd crate. (Latest unreleased commit is 0.8.) Most of the crates.io ecosystem is now using 0.9. I've run into issues where I can't depend on a desired dependency because it already upgraded to version 0.9 and cargo refuses to compile multiple X.Y versions of zstd-sys.

Are there any plans to merge this and get a new release of this crate out the door?

@brianc118
Copy link

brianc118 commented Jan 24, 2022

Bump :) zstd create is now up to 0.10.0+zstd.1.5.2 so this PR would need to be updated too. I can make a PR for this if @vmalloc doesn't update this one.

@vmalloc
Copy link
Author

vmalloc commented Jan 25, 2022

@brianc118 I updated the PR, but I think nobody is responding here... I'm wondering what's the current status of this crate, and whether or not it has been abandoned by the author...

@Nemo157
Copy link
Member

Nemo157 commented Jan 25, 2022

Sorry, I've been a bit busy lately. I will do a quick series of patch releases with the different major versions of zstd so if people do want to pin specific versions they can.

@Nemo157 Nemo157 changed the title Update zstd dependency Update zstd to 0.10 Jan 25, 2022
@Nemo157
Copy link
Member

Nemo157 commented Jan 25, 2022

bors r+

bors bot added a commit that referenced this pull request Jan 25, 2022
131: Update zstd to 0.10 r=Nemo157 a=vmalloc



Co-authored-by: Rotem Yaari <rotemy@ip-192-168-128-148.eu-west-1.compute.internal>
@codecov-commenter
Copy link

Codecov Report

Merging #131 (15a0ab8) into prīmum (ca078b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           prīmum     #131   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files          92       92           
  Lines        2950     2950           
=======================================
  Hits         2301     2301           
  Misses        649      649           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca078b4...15a0ab8. Read the comment docs.

@bors bors bot closed this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants