Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CDATA parsing returning empty string when value = 0 #451

Merged
merged 1 commit into from Mar 31, 2022
Merged

Fix CDATA parsing returning empty string when value = 0 #451

merged 1 commit into from Mar 31, 2022

Conversation

ndelanou
Copy link
Contributor

Purpose / Goal

In V4, parsing CDATA with value 0 returns an empty string
In v3, it returned the string '0'

Type

Please mention the type of PR

  • [X]Bug Fix
  • [ ]Refactoring / Technology upgrade
  • [ ]New Feature

Input

<latitude>
    <![CDATA[ 0 ]]>
</latitude>

Expected output

latitude = 0

Actual output

latitude = ''

@coveralls
Copy link

coveralls commented Mar 31, 2022 •
edited

Coverage Status

Coverage remained the same at 98.561% when pulling 8ac88d1 on ndelanou:master into 0a43d42 on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit 7cf67e6 into NaturalIntelligence:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndelanou @coveralls @amitguptagwl