Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ReferenceError when Bundled with Strict #431

Conversation

aheissenberger
Copy link
Contributor

Purpose / Goal

Fix #430 to allow library to work in environments where bundler set javascript to strict.
Add missing let in for-in loop.

Type

Please mention the type of PR

  • [X]Bug Fix
  • [ ]Refactoring / Technology upgrade
  • [ ]New Feature

@amitguptagwl amitguptagwl merged commit 68ccca0 into NaturalIntelligence:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: attr is not defined / Javascript Strict needs variables in for loops defined
2 participants