Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tns plugin add fails when tns-android key is missing in package.json of the app #3123

Open
NathanaelA opened this issue Sep 14, 2017 · 6 comments

Comments

@NathanaelA
Copy link
Contributor

Did you verify this is a real problem by searching

Yes, here.

Tell us about the problem

I do a lot of plugin development ;-) I tend to do
tns plugin add ../src or tns plugin add pluginname-1.0.0.tgz
All of these will cause nativescript to throw a error

TypeError: Cannot read property 'version' of undefined
    at PluginsService.getInstalledFrameworkVersion (/usr/local/lib/node_modules/nativescript/lib/services/plugins-service.js:261:29)
    at PluginsService.isPluginDataValidForPlatform (/usr/local/lib/node_modules/nativescript/lib/services/plugins-service.js:265:48)
    at PluginsService.<anonymous> (/usr/local/lib/node_modules/nativescript/lib/services/plugins-service.js:57:26)
    at next (native)
    at /usr/local/lib/node_modules/nativescript/lib/services/plugins-service.js:7:71
    at __awaiter (/usr/local/lib/node_modules/nativescript/lib/services/plugins-service.js:3:12)
    at action (/usr/local/lib/node_modules/nativescript/lib/services/plugins-service.js:56:83)
    at PluginsService.<anonymous> (/usr/local/lib/node_modules/nativescript/lib/services/plugins-service.js:253:27)
    at next (native)
    at /usr/local/lib/node_modules/nativescript/lib/services/plugins-service.js:7:71

The issue is inserted in the package.json: "nativescript-pluginname": "file:<path to dir>",

When you attempt to get version numbers, "file:....." doesn't match and causes the above error.

Which platform(s) does your issue occur on?

Both

Please provide the following version numbers that your issue occurs with:

At least since TNS 3.0, still happening in 3.2

Please tell us how to recreate the issue in as much detail as possible.

tns plugin add ../src from a demo folder

@dtopuzov
Copy link
Contributor

dtopuzov commented Nov 8, 2017

This looks as duplicate of #3028
@NathanaelA can you please confirm you hit the issue only with npm5?

@NathanaelA

This comment was marked as abuse.

@rosen-vladimirov
Copy link
Contributor

I've successfully reproduced this issue by running the following steps:

  1. tns create myApp
  2. cd myApp
  3. tns prepare android
  4. open package.json and remove the tns-android key from it
  5. tns plugin add nativescript-barcodescanner

The problem arises when the platforms dir exists, but the entry for respective runtime in package.json does not exist for some reason. So the issue is not related to local plugins only.

@dtopuzov
Copy link
Contributor

dtopuzov commented Jun 8, 2018

Still reproducible with {N} 4.1.

@dtopuzov dtopuzov changed the title TNS plugin add <path to local plugin> causes issues tns plugin add fails when tns-android key is missing in package.json of the app Jun 8, 2018
@nodetech-architecture
Copy link

I'm having this issue

@miroslavaivanova
Copy link
Contributor

Still reproducible with {N} 5.1.

@rosen-vladimirov rosen-vladimirov added this to Inbox in CLI Team May 15, 2019
tomups added a commit to tomups/nativescript-cscreenshot that referenced this issue Nov 4, 2020
Otherwise it fails when doing `ns plugin add @enduco/nativescript-cscreenshot` (seems a quite old bug of the NS CLI, see NativeScript/nativescript-cli#3123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CLI Team
  
Inbox
Development

No branches or pull requests

5 participants