Python 3.12 support #780
Merged
Python 3.12 support #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 89 89
Lines 6405 6405
=======================================
Hits 6383 6383
Misses 22 22 ☔ View full report in Codecov by Sentry. |
|
While Poetry cannot install TensorFlow 2.16 because of its wrong package metadata, pip can, see branch python3.12-support-tf-via-pip. TF 2.16 also upgrades to Keras 3, which required a few changes. So it could be an option to install TF with pip instead of Poetry; this would allow upgrading to TF 2.16 and thus use of NN ensemble on Python 3.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annif on Python 3.12 already works when the optional dependencies stwfsapy and tensorflow-cpu are not installed or even declared as dependecies.
Closes #779.At the moment does not fully close #779 because stwfsapy and NN ensemble will not work on Python 3.12.