nwis_client: SyntaxError

[jarq6c]

Issue

hydrotools.nwis_client version 3.0.6 raises a SyntaxError on import.
@aaraney would you mind looking into this?

Environment:

Python 3.8.10 (default, Jun  4 2021, 15:09:15)
[GCC 7.5.0] :: Anaconda, Inc. on linux

Duplicate

import hydrotools.nwis_client

Error

'base_url:typing.Union[str, yarl.URL, NoneType]=None' of kind 'POSITIONAL_OR_KEYWORD' follows 'cache:CacheBackend=None' of kind 'KEYWORD_ONLY'
Traceback (most recent call last):
  File "/home/jason.regina/Projects/nwis_test/miniconda3/lib/python3.8/site-packages/aiohttp_client_cache/docs/forge_utils.py", line 32, in wrapper
    return revision(target_function)
  File "/home/jason.regina/Projects/nwis_test/miniconda3/lib/python3.8/site-packages/forge/_revision.py", line 330, in __call__
    next_.validate()
  File "/home/jason.regina/Projects/nwis_test/miniconda3/lib/python3.8/site-packages/forge/_signature.py", line 1344, in validate
    raise SyntaxError(
SyntaxError: 'base_url:typing.Union[str, yarl.URL, NoneType]=None' of kind 'POSITIONAL_OR_KEYWORD' follows 'cache:CacheBackend=None' of kind 'KEYWORD_ONLY'

[jarq6c]

Note: Encountered this error while trying to troubleshoot #150

[aaraney]

@jarq6c, thanks for bringing this to my attention. I will take a look at it.

[aaraney]

This looks like it might be a downstream issue with aiohttp_client_cache. I was able to reproduce the issue by just importing aiohttp_client_cache:

import aiohttp_client_cache

> 'base_url:typing.Union[str, yarl.URL, NoneType]=None' of kind 'POSITIONAL_OR_KEYWORD' follows 'cache:CacheBackend=None' of kind 'KEYWORD_ONLY'
Traceback (most recent call last):
  File "/Users/araney/github/test_hydrotools/venv/lib/python3.8/site-packages/aiohttp_client_cache/docs/forge_utils.py", line 32, in wrapper
    return revision(target_function)
  File "/Users/araney/github/test_hydrotools/venv/lib/python3.8/site-packages/forge/_revision.py", line 330, in __call__
    next_.validate()
  File "/Users/araney/github/test_hydrotools/venv/lib/python3.8/site-packages/forge/_signature.py", line 1344, in validate
    raise SyntaxError(
SyntaxError: 'base_url:typing.Union[str, yarl.URL, NoneType]=None' of kind 'POSITIONAL_OR_KEYWORD' follows 'cache:CacheBackend=None' of kind 'KEYWORD_ONLY'

[aaraney]

I will try rolling back the version of aiohttp-client-cache and see if this resolves the issue. v0.5.1 of aiohttp-client-cache was released on September 10, 2021 so I would have hoped that other tests would have caught this before then. Ill update the ticket with my findings shortly.

[aaraney]

I found that rolling back aiohttp-client-cache did not mitigate the issue. My guess is this is related to aiohttp's October 31, 2021 release. Going to try rolling back aiohttp from 3.8.0.

[aaraney]

Okay, so I just verified that the issue is with 3.8.0 of aiohttp. I rolled the version back to aiohttp==3.7.4.post0 and the issue disappeared. Ill open an issue in aiohttp-client-cache to let them know of the issue. Ill also release a new patched version of _restclient and pin aiohttp to 3.7.4.post0.

[aaraney]

pinning self opened issue aiohttp-client-cache #103

[aaraney]

redeployed _restclient (see #154)

update using:

pip install -U hydrotools._restclient

[aaraney]

I heard back from the maintainer of aiohttp_client_cache:

Thanks for reporting! Looks like a new base_url param was added in aio-libs/aiohttp#6129, and for some reason it's positional-or-keyword instead of keyword-only like the rest of the params. I'll get that fixed shortly.

[jarq6c]

Thanks for doing all the leg work!

[aaraney]

For sure! Have a nice evening!

[jarq6c]

Just confirming that the error was fixed on my end by updating _restclient