Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try migrating make-release.sh to a cargo xtask #236

Open
cschwan opened this issue Jul 18, 2023 · 2 comments
Open

Try migrating make-release.sh to a cargo xtask #236

cschwan opened this issue Jul 18, 2023 · 2 comments
Assignees

Comments

@cschwan
Copy link
Contributor

cschwan commented Jul 18, 2023

I revisited the point raised by @alecandido in this comment and it seems that cargo xtask could be a good fit. To summarize it in one point: instead of running ./make-release.sh X.Y.Z we'd run cargo xtask make-release X.Y.Z. The advantages are that it would run everywhere, not only where we have a shell. Maybe even more importantly, cargo xtask would also give us the opportunity to install and post-process manpages, which is a bit of a sore point right now (they're installed into a temporary directory whenever someone reads them and then they're subsequently removed).

@alecandido
Copy link
Member

alecandido commented Jul 18, 2023

I like a lot the idea of using Rust code itself, and together with xshell (by the same author) it seems a good fit.

However, thinking about stability and support, I wonder if it's better to favor a different task runner, i.e. cargo make, which seems much more popular...
(but it wouldn't solve the language controversy...)

@cschwan
Copy link
Contributor Author

cschwan commented Aug 31, 2023

An xtask applet has been added with commit 087b7b7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants