Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogFactory should only know ITargetWithFilterChain #5486

Open
snakefoot opened this issue Mar 24, 2024 · 0 comments
Open

LogFactory should only know ITargetWithFilterChain #5486

snakefoot opened this issue Mar 24, 2024 · 0 comments
Milestone

Comments

@snakefoot
Copy link
Contributor

snakefoot commented Mar 24, 2024

  • Change this method with NLog v6 to completely disconnect LogFactory from Targets/Layouts-dependency-tree
    • Remove LoggingRule-List-parameter
    • Return ITargetWithFilterChain[]
        internal TargetWithFilterChain[] BuildLoggerConfiguration(string loggerName, List<LoggingRule> loggingRules)
        {
            ...
        }

Consider extending TestTrimPublish to verify that ony using LogManager.GetCurrentClassLogger().Info("Hello") gives minimal target-file-size.

@snakefoot snakefoot added this to the 6.0 milestone Mar 24, 2024
@snakefoot snakefoot changed the title LogFactory should change to only know ITargetWithFilterChain LogFactory changed to only know ITargetWithFilterChain Mar 24, 2024
@snakefoot snakefoot changed the title LogFactory changed to only know ITargetWithFilterChain LogFactory should only know ITargetWithFilterChain Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant