Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RegEx from Replace and LoggingRule Pattern #5445

Open
snakefoot opened this issue Dec 28, 2023 · 0 comments
Open

Remove RegEx from Replace and LoggingRule Pattern #5445

snakefoot opened this issue Dec 28, 2023 · 0 comments
Labels
breaking change Breaking API change (different to semantic change)
Milestone
6.0

Comments

@snakefoot
Copy link
Contributor

snakefoot commented Dec 28, 2023 •
edited

RegularExpression is a heavy dependency for a logging library, when using AOT.

Instead create dedicated RegEx-Replace-LayoutRenderer, and change the MultiplePatternLoggerNameMatcher to not rely on RegEx.
@snakefoot snakefoot added this to the 6.0 milestone Dec 28, 2023
@snakefoot snakefoot added the breaking change Breaking API change (different to semantic change) label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Breaking API change (different to semantic change)
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
1 participant
@snakefoot