Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced question.md issue-template with contact_links (fix bom) #4921

Merged
merged 1 commit into from
May 13, 2022

Conversation

snakefoot
Copy link
Contributor

Followup to #4912

@304NotModified
Copy link
Member

We could only test it after merge? Or maybe at a fork?

I see the indents on https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser, so not sure if this would fix things

@snakefoot
Copy link
Contributor Author

Yes testing it now. there is some BOM-issue

@snakefoot snakefoot marked this pull request as ready for review May 13, 2022 10:57
@snakefoot
Copy link
Contributor Author

now it works

@snakefoot snakefoot changed the title Replaced question.md issue-template with contact_links (fix indent) Replaced question.md issue-template with contact_links (fix bom) May 13, 2022
@304NotModified 304NotModified merged commit eb1f8d3 into NLog:dev May 13, 2022
@304NotModified
Copy link
Member

Yes indeed! Nice!

@sonarcloud
Copy link

sonarcloud bot commented May 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@snakefoot snakefoot deleted the issue_template_question branch July 30, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants