Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log4JXmlEventLayoutRenderer - IncludeEventProperties default = true #4891

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Log4JXmlEventLayoutRenderer - IncludeEventProperties default = true #4891

merged 1 commit into from
Apr 25, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Apr 25, 2022 •
edited

Better defaults for Log4J-XML where event-properties are included by default in log4net.

But exclude NLogViewer-target since it is special, and has its own standards (IncludeNLogData = true)

@snakefoot snakefoot added this to the 5.0 (new) milestone Apr 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot enabled auto-merge (squash) April 25, 2022 19:13
@snakefoot snakefoot merged commit 837ecf0 into NLog:dev Apr 25, 2022
@snakefoot snakefoot added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Apr 26, 2022
@snakefoot
Copy link
Contributor Author

Updated wiki: https://github.com/NLog/NLog/wiki/Log4JXmlEventLayout

Updated wiki: https://github.com/NLog/NLog/wiki/Log4JXMLEvent-Layout-Renderer

@snakefoot snakefoot mentioned this pull request May 14, 2022
Merged
@snakefoot snakefoot deleted the log4j-xml-include-properties branch July 30, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) needs documentation on wiki network/NLogViewer-target size/XS
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snakefoot @304NotModified