-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SpecialFolder UserApplicationDataDir for internalLogFile when parsing nlog.config #4863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are long names, but I think those are the best options and it's consistent. So LGTM :)
PS I'm on holiday with limited internet connection.
Maybe we should document the layout renderer with dashes on https://nlog-project.org/config/?tab=layout-renderers ? |
Think it will be confusing with the very simple layout-support for |
Kudos, SonarCloud Quality Gate passed! |
Decided that ApplicationDataDir was too generic. One might think it would be the directory of the running application. Created #4868 |
Updated wiki: https://github.com/NLog/NLog/wiki/Internal-Logging |
Can the internal-logging wiki be updated to specify where the locations re what was posted above? but also for linux, i cant find what these resolve to in linux online ${commonApplicationDataDir} - C:\ProgramData |
SpecialFolders on Linux is platform dependent. But maybe this page can help:
https://github.com/NLog/NLog/wiki/Special-Folder-Layout-Renderer
https://learn.microsoft.com/en-us/dotnet/api/system.environment.specialfolder
|
Trying to resolve #4861
Introduces support for these symbol-types (both for internalLogFile and normal layouts):
${commonApplicationDataDir}
-C:\ProgramData
${userApplicationDataDir}
-C:\Users\%USERNAME%\AppData\Roaming
${userLocalApplicationDataDir}
-C:\Users\%USERNAME%\AppData\Local