Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SpecialFolder UserApplicationDataDir for internalLogFile when parsing nlog.config #4863

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Apr 2, 2022

Trying to resolve #4861

Introduces support for these symbol-types (both for internalLogFile and normal layouts):

  • ${commonApplicationDataDir} - C:\ProgramData
  • ${userApplicationDataDir} - C:\Users\%USERNAME%\AppData\Roaming
  • ${userLocalApplicationDataDir} - C:\Users\%USERNAME%\AppData\Local

@snakefoot snakefoot added the enhancement Improvement on existing feature label Apr 2, 2022
@snakefoot snakefoot added this to the 5.0 (new) milestone Apr 2, 2022
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are long names, but I think those are the best options and it's consistent. So LGTM :)

PS I'm on holiday with limited internet connection.

@304NotModified
Copy link
Member

Maybe we should document the layout renderer with dashes on https://nlog-project.org/config/?tab=layout-renderers ?

@snakefoot
Copy link
Contributor Author

Maybe we should document the layout renderer with dashes on https://nlog-project.org/config/?tab=layout-renderers ?

Think it will be confusing with the very simple layout-support for internalLogFile-option.

@snakefoot snakefoot closed this Apr 2, 2022
@snakefoot snakefoot reopened this Apr 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit dc4b1fd into NLog:dev Apr 2, 2022
@snakefoot snakefoot changed the title Support SpecialFolder ApplicationDataDir for internalLogFile when parsing nlog.config Support SpecialFolder UserApplicationDataDir for internalLogFile when parsing nlog.config Apr 4, 2022
@snakefoot
Copy link
Contributor Author

Decided that ApplicationDataDir was too generic. One might think it would be the directory of the running application. Created #4868

@snakefoot
Copy link
Contributor Author

@snakefoot snakefoot added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Apr 26, 2022
@cedd82
Copy link

cedd82 commented Oct 24, 2022

Updated wiki: https://github.com/NLog/NLog/wiki/Internal-Logging

Can the internal-logging wiki be updated to specify where the locations re what was posted above? but also for linux, i cant find what these resolve to in linux online

${commonApplicationDataDir} - C:\ProgramData
${userApplicationDataDir} - C:\Users%USERNAME%\AppData\Roaming
${userLocalApplicationDataDir} - C:\Users%USERNAME%\AppData\Local

@snakefoot
Copy link
Contributor Author

snakefoot commented Oct 24, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) enhancement Improvement on existing feature needs documentation on wiki size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internalLogFile Appdatadir on Linux & osx
3 participants