New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added various null checks to improve code quality #4838

Merged

snakefoot merged 3 commits into NLog:dev from kurnakovv:dev

Mar 12, 2022

Contributor

kurnakovv commented Mar 12, 2022

Thanks for NLog, it's very helpful tool! I think this changes can helps.

30820cf There is not enough null check, are above we are already use null check for compiledConstructor variable.
d44ba4c Potential NullReferenceException, because below these changes, we are already have the null check. Right here
c9299ec There is not enough null check, are above we are already use null check for value variable.

kurnakovv added 3 commits

March 12, 2022 13:44


          Add null check for compiledConstructor

30820cf


          Add null check for newMessageProperties

d44ba4c


          Add null check for value in TryFormatToString

c9299ec

welcome bot commented Mar 12, 2022

Thanks for opening this pull request!
We will try to review this soon! Please note that pull requests with unit tests are earlier accepted 👼

pull-request-size bot added the size/XS label

sonarcloud bot commented Mar 12, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

snakefoot merged commit 64907c3 into NLog:dev

welcome bot commented Mar 12, 2022

Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks!

snakefoot added this to the 5.0 (new) milestone

snakefoot changed the title ~~Added required null checks~~ Added various null checks to improve code quality

snakefoot added the refactoring label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment