Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate ConditionParseException into NLogConfigurationException #4812

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 27, 2022

When using throwConfigExceptions="true", then failure to parse ConditionExpressions should not be ignored.

@snakefoot snakefoot added enhancement Improvement on existing feature nlog-configuration labels Feb 27, 2022
@snakefoot snakefoot added this to the 5.0 (new) milestone Feb 27, 2022
@snakefoot snakefoot changed the title Handle ConditionParseException as NLogConfigurationException Translate ConditionParseException into NLogConfigurationException Feb 27, 2022
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.6% 81.6% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit 668c554 into NLog:dev Feb 27, 2022
@snakefoot snakefoot added the breaking behavior change Same API, different result label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking behavior change Same API, different result enhancement Improvement on existing feature nlog-configuration size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant