Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLog 5.0 Ready for delivery #4802

Merged
merged 2 commits into from
May 16, 2022
Merged

NLog 5.0 Ready for delivery #4802

merged 2 commits into from
May 16, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 21, 2022 •
edited

@snakefoot snakefoot added this to the 5.0 (new) milestone Feb 21, 2022
@snakefoot snakefoot closed this Feb 21, 2022
@snakefoot snakefoot reopened this Feb 21, 2022
@snakefoot snakefoot closed this Feb 22, 2022
@snakefoot snakefoot reopened this Feb 22, 2022
@snakefoot snakefoot closed this Feb 26, 2022
@snakefoot snakefoot reopened this Feb 26, 2022
@snakefoot snakefoot force-pushed the nlog5-ready branch 2 times, most recently from 413cd53 to 59739c2 Compare February 27, 2022 18:10
@snakefoot
Copy link
Contributor Author

snakefoot commented Feb 28, 2022 •
edited

@304NotModified Anything more to include, before merging ?

Would prefer to have NLog/NLog.github.io#181 merged together with the NLog 5.0-release

And to have NLog/NLog.github.io#183 merged, so I can continue the work with actually adding the new NLog 5.0-packages to the list (Ex. NLog.Database-nuget-package)

@304NotModified
Copy link
Member

I think we have to update the xsd online?

@snakefoot
Copy link
Contributor Author

snakefoot commented Mar 2, 2022 via email •
edited

@snakefoot snakefoot force-pushed the nlog5-ready branch 5 times, most recently from e6faf1d to 75078a4 Compare March 6, 2022 13:31
@snakefoot snakefoot closed this Mar 6, 2022
@snakefoot snakefoot reopened this Mar 6, 2022
@snakefoot snakefoot force-pushed the nlog5-ready branch 5 times, most recently from 6a9854c to 23ad02d Compare March 12, 2022 07:57
@snakefoot snakefoot force-pushed the nlog5-ready branch 2 times, most recently from 33317ba to ae47eff Compare March 26, 2022 15:41
@snakefoot
Copy link
Contributor Author

@304NotModified I guess we are super close to perform the official release ? (Only have #4887 in queue)

@304NotModified
Copy link
Member

guess only some docs work? https://github.com/NLog/NLog/issues?q=is%3Aopen+is%3Aissue+milestone%3A%225.0+%28new%29%22

@snakefoot
Copy link
Contributor Author

snakefoot commented Apr 25, 2022 •
edited

guess only some docs work? https://github.com/NLog/NLog/issues?q=is%3Aopen+is%3Aissue+milestone%3A%225.0+%28new%29%22

I was thinking the release-build-first then followed by release-news-post, and finally look at generating the source-code-docs (Since NLog wiki is already updated).

See also: https://github.com/NLog/NLog/pulls?page=1&q=is%3Apr+label%3A%22needs+documentation+on+wiki%22+is%3Aclosed+-label%3A%22documentation+done%22+is%3Amerged&utf8=%E2%9C%93

@snakefoot snakefoot force-pushed the nlog5-ready branch 3 times, most recently from 1b08a4e to 2dc678c Compare May 1, 2022 11:12
@snakefoot
Copy link
Contributor Author

@304NotModified Any objections on pushing the merge-button, and building NLog 5.0 RTM ?

@snakefoot snakefoot force-pushed the nlog5-ready branch 3 times, most recently from 01a5786 to 0fddce6 Compare May 8, 2022 09:29
@snakefoot snakefoot closed this May 8, 2022
@snakefoot snakefoot reopened this May 8, 2022
@304NotModified
Copy link
Member

304NotModified commented May 13, 2022 •
edited

@snakefoot

Will try to double check today/this weekend!

Im a bit behind all the notifications

@snakefoot snakefoot force-pushed the nlog5-ready branch 5 times, most recently from d0fc13b to 256da80 Compare May 15, 2022 09:40
@304NotModified
Copy link
Member

Will be tomorrow (Monday) evening. I have blocked some time for it.

@sonarcloud
Copy link

sonarcloud bot commented May 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@304NotModified 304NotModified merged commit 2e132d9 into NLog:dev May 16, 2022
@304NotModified
Copy link
Member

304NotModified commented May 16, 2022 •
edited

@snakefoot here we go!

@304NotModified
Copy link
Member

oops broke the link - my bad!

@snakefoot
Copy link
Contributor Author

The release looks great, and thank you for fixing the broken link that I forgot.

Really like the ReadMe you created for the NLog nuget-package. Good idea with using the headlines.

@304NotModified
Copy link
Member

thx.

No I broke the link and fixed it with a script on the 404 site 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@304NotModified 304NotModified

Labels
size/M version
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snakefoot @304NotModified