Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExceptionLayoutRenderer - CompileFormat should check ThrowConfigExceptions #4234

Open
snakefoot opened this issue Jan 10, 2021 · 0 comments
Open

ExceptionLayoutRenderer - CompileFormat should check ThrowConfigExceptions #4234

snakefoot opened this issue Jan 10, 2021 · 0 comments
Labels
enhancement Improvement on existing feature up-for-grabs
Milestone
6.0

Comments

@snakefoot
Copy link
Contributor

snakefoot commented Jan 10, 2021 •
edited

Instead of silently accepting this when ThrowConfigExceptions = true

  • ${exception:format=string}

Then it should fail by deferring validation from Format-property-assignment to InitializeLayoutRenderer().

If Formats-property-collection is empty (because parsing failed), then it should fallback to ExceptionRenderingFormat.ToString (Unless InnerFormats has been assigned).
@snakefoot snakefoot added enhancement Improvement on existing feature up-for-grabs labels Jan 10, 2021
@snakefoot snakefoot added this to the 5.0 (new) milestone Jan 10, 2021
@snakefoot snakefoot modified the milestones: 5.0 (new), 6.0 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement on existing feature up-for-grabs
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
1 participant
@snakefoot