Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.6.5 #3465

Merged
merged 15 commits into from Jun 13, 2019
Merged

Release 4.6.5 #3465

merged 15 commits into from Jun 13, 2019

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Jun 9, 2019 •
edited

note, some commits are already in master

@codecov-io
Copy link

codecov-io commented Jun 9, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@7dfbf65). Click here to learn what that means.
The diff coverage is 55%.

@@           Coverage Diff            @@
##             master   #3465   +/-   ##
========================================
  Coverage          ?     80%           
========================================
  Files             ?     361           
  Lines             ?   28686           
  Branches          ?    3829           
========================================
  Hits              ?   22959           
  Misses            ?    4619           
  Partials          ?    1108

@304NotModified 304NotModified added this to the 4.6.5 milestone Jun 11, 2019
@304NotModified
Copy link
Member Author

will reopen if all merged

304NotModified and others added 3 commits June 13, 2019 02:04
@304NotModified
Added test: <variable> with attr and <value> (#3479)
d85b7f5
@304NotModified
XSD: Support <value> in <variable> (#3478)
75afe1a 
* Support value in variable
@snakefoot @304NotModified
FilteringTargetWrapper - Fix XSD for Filter-property (#3476)
218961f 
* FilteringTargetWrapper - Fix XSD for Filter-property

* FilteringTargetWrapper - Fix XSD for Filter-property (never as attribute)

* FilteringTargetWrapper - Updated unit-test to fail when adding unwanted attribute

* Added tests
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 13, 2019
@304NotModified
Copy link
Member Author

reopen to check 218961f

@304NotModified 304NotModified changed the title Release/4.6.5 Release 4.6.5 (WIP) Jun 13, 2019
@304NotModified 304NotModified changed the title Release 4.6.5 (WIP) Release 4.6.5 Jun 13, 2019
@304NotModified
XSD test for NLog.Schema (#3487)
1fb0b97 
* Added XSD test

* Integrate into build script
@304NotModified 304NotModified merged commit eccb737 into master Jun 13, 2019
@repo-ranger repo-ranger bot deleted the release/4.6.5 branch June 13, 2019 23:56
@304NotModified
Copy link
Member Author

double checked xsd in behavior en diff, both OK 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
4.6.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@304NotModified @codecov-io @snakefoot @Kahath