-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoggingConfiguration - Rollback static Reload-method #3335
LoggingConfiguration - Rollback static Reload-method #3335
Conversation
a3f481d
to
ed0109e
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3335 +/- ##
======================================
+ Coverage 80% 80% +<1%
======================================
Files 356 356
Lines 28226 28222 -4
Branches 3763 3762 -1
======================================
+ Hits 22579 22586 +7
+ Misses 4558 4549 -9
+ Partials 1089 1087 -2 |
Hi, thanks for the PR, but would it be more logical to have something like this: LogManager.ReloadConfiguration();
// and/or
LogFactory.ReloadConfiguration(); I find the "active" a bit unusual |
I need a method on LoggingConfiguraion (or method that takes LoggingConfiguration as parameter), that allows one to reload the config with respect to KeepVariablesOnReload (For use in NLog.Extension.Logging). But also thought it would be nice to provide a solution for #3304 But maybe I should just remove the new introduced method completely. Since I can probably implement this variable copy manually in NLog.Extension.Logging. |
I'm also doubting this addition makes things easier, so for now I think
Is good enough |
But it will not support |
Can't be do |
ed0109e
to
7e54a45
Compare
Sounds like something for NLog 5.0. Lets just rollback #3306 |
I'm confused. You forced pushed different content? Won't it be more logical to close the old PR and create a new one? |
Hate to waste a precious PulRequest-number :) |
This is still valid, isn't? |
Yes it removes an unnecessary public method.
|
Rollback of #3306 until a better solution comes around for NLog/NLog.Extensions.Logging#283