-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimpleStringReader: fix DebuggerDisplay value #3195
SimpleStringReader: fix DebuggerDisplay value #3195
Conversation
added tests
Need to change the config * .yml, |
Well the code is only activated when making DEBUG-builds. For release-builds then the code is non-existing. |
That's right, but the test result is not obvious. At your discretion. |
The AppVeyor-build runs the final code-coverage test using a DEBUG-build for proper symbol-information. |
Thanks for the PR! The build fails, see this error:
Could you please fix this? Thanks 😊 (See also build log) |
Codecov Report
@@ Coverage Diff @@
## dev #3195 +/- ##
======================================
+ Coverage 80% 80% +<1%
======================================
Files 354 354
Lines 27909 27913 +4
Branches 3706 3707 +1
======================================
+ Hits 22251 22271 +20
+ Misses 4597 4579 -18
- Partials 1061 1063 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, but please do some renames and a file move - see notes. Then I could merge it :)
I fixed all and changed the logic of |
Thanks! Merged! :) |
fixes #3194