Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable base path for Aerie UI #611

Open
parkerabercrombie opened this issue Apr 28, 2023 · 2 comments
Open

Allow configurable base path for Aerie UI #611

parkerabercrombie opened this issue Apr 28, 2023 · 2 comments
Assignees
Labels
feature New feature or request investigate Issue needs further investigation

Comments

@parkerabercrombie
Copy link

Checked for duplicates

Yes - I've already checked

Alternatives considered

Yes - and alternatives don't suffice

Related problems

Deploying the Aerie UI to a non-standard path (e.g., /aerie) requires modifying the code and rebuilding the image.

Describe the feature request

I need or want [...]We need to host Aerie at a /aerie base path (i.e., https://ourhost/aerie). In order to make the Aerie UI work with the /aerie base path we have to modify svelte.js to hack in the desired base path, and then rebuld the UI package:

 sed -i "s#base: \'\'#base: \'/${BASE_PATH}\'#g" svelte.config.js

It would be really nice if this could be configurable without a full rebuild.Right now we have a whole Jenkins pipeline setup just to get around this limitation.

@parkerabercrombie parkerabercrombie added the feature New feature or request label Apr 28, 2023
@camargo
Copy link
Member

camargo commented Apr 28, 2023

Noting for completeness the workaround is documented here. It seems the Svelte Kit issue blocking this has been closed. I'll take a look next week to see if this is still a limitation.

@camargo camargo added the investigate Issue needs further investigation label May 1, 2023
@camargo camargo self-assigned this May 1, 2023
@camargo
Copy link
Member

camargo commented Jun 12, 2023

Just an update here. I did not see an obvious way to do this so I put in a question to the SK team: sveltejs/kit#10147, will update here with findings.

@mattdailis mattdailis assigned mattdailis and unassigned camargo Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request investigate Issue needs further investigation
Projects
Status: Todo
Development

No branches or pull requests

3 participants